Fix: generic filaments not showing on list #74

New Issue

MrUnknownDE · 2026-04-05T16:18:21+02:00

MrUnknownDE commented

2026-04-05 16:18:21 +02:00

Originally created by @Sabriel-Koh on 3/30/2026

Description

This PR covers a few fixes related to the printer/filament selection dialog.

It should help some of the recent issues with Generic filaments, but I think it's possible that there may still be edge cases/sources of confusion that I have yet to find.

Printer/filament selection
- Not sure if anyone else had this issue, but while working on this PR I kept having issues where the first time I opened the dialogs, none of my current selections would actually be selected. However, it would work as expected after that.(WebGuideDialog.cpp:1127)
  
  Refactored the code a little bit, calling SaveProfileData first to ensure that m_ProfileJson is updated, and placed them both in the same CallAfter call to make sure SaveProfileData is called first.

Bug:

Fixed:

Printer's default filaments not being selected when going to the filament selection section of the initial setup
- Seems like it was just a feature not in the WebGuideDialog class, unlike the previous setup wizard implementation.

Bug:

Fixed:

Printer's default filament being selected, even if unavailable, making it seem like an extra filament was added (and also doesn't reappear on restart)
- When the printer is loaded, an attempt to select its default filament is made, but the selection does not check for availability before it does so. Fixed by adding one.

Bug (only the CoPE was explicitly selected):

Fixed:

Fix @\System filaments being added without the postfix
- This tended to incorrectly add Bambu Lab specific filaments instead, since some are named like "Generic PLA" vs the "Generic PLA @\System" for the truly generic profile.
  Fixes #12297
  Fixes #12922
Sometimes, when there is only 1 item in a sub-dropdown, the sub-dropdown does not show
- In the dropdown code, there is a shortcut to return the hover_item index directly if the number of items shown is equal to the number of items in the combobox. However, for groups containing only 1 item, the grouping is incorrectly counted as an item itself, causing the subdropdown to not render. I will note that I saw cases where 1 item dropdowns rendered correctly, and think it was likely due to the presence of OTHER groups that contained more than 1 item (thus causing the dropdown to skip that shortcut).

Bug:

Fixed:

Tests

Checking that the selected filaments remain selected in the dialog

Creality K1C tests

Added Creality K1C on initial setup, cleared filament selection, and only selected Generic CoPE
Added Generic ABS and Creality Generic ABS (one displays as "ABS" and the other as "Creality Generic ABS" in the subgroup
Added a few other ABS filaments from non-generic vendors
Removed all but Creality Generic ABS
Removed Creality Generic ABS and added all Generic vendor filaments

*Originally created by @Sabriel-Koh on 3/30/2026* # Description This PR covers a few fixes related to the printer/filament selection dialog. It should help some of the recent issues with Generic filaments, but I think it's possible that there may still be edge cases/sources of confusion that I have yet to find. - Printer/filament selection - Not sure if anyone else had this issue, but while working on this PR I kept having issues where the first time I opened the dialogs, none of my current selections would actually be selected. However, it would work as expected after that.(WebGuideDialog.cpp:1127) Refactored the code a little bit, calling SaveProfileData first to ensure that m_ProfileJson is updated, and placed them both in the same CallAfter call to make sure SaveProfileData is called first. Bug: <img width="1482" height="823" alt="image" src="https://github.com/user-attachments/assets/f88fa6e0-f8ce-41d4-b4c5-5455d40f012a" /> <img width="1049" height="537" alt="image" src="https://github.com/user-attachments/assets/857ba6bd-43cb-4e0f-87f9-a6f201182fea" /> Fixed: <img width="1229" height="729" alt="image" src="https://github.com/user-attachments/assets/babaccc9-e32d-44fc-890b-9231d7de5a39" /> <img width="987" height="619" alt="image" src="https://github.com/user-attachments/assets/40146ffb-cf1e-4064-b6ec-f58c83ef3434" /> - Printer's default filaments not being selected when going to the filament selection section of the initial setup - Seems like it was just a feature not in the WebGuideDialog class, unlike the previous setup wizard implementation. Bug: <img width="818" height="670" alt="image" src="https://github.com/user-attachments/assets/f10ff202-545a-4052-844e-7aa26f41845d" /> Fixed: <img width="830" height="676" alt="image" src="https://github.com/user-attachments/assets/05a1fecd-2086-4b6b-a6b4-52fcbf628b77" /> - Printer's default filament being selected, even if unavailable, making it seem like an extra filament was added (and also doesn't reappear on restart) - When the printer is loaded, an attempt to select its default filament is made, but the selection does not check for availability before it does so. Fixed by adding one. Bug (only the CoPE was explicitly selected): <img width="595" height="437" alt="image" src="https://github.com/user-attachments/assets/6311b749-d9ed-46a1-a9a5-66b7ff6ad473" /> Fixed: <img width="546" height="451" alt="image" src="https://github.com/user-attachments/assets/0fdc0233-4bee-411e-8336-aa4a9d4a0716" /> - Fix @\System filaments being added without the postfix - This tended to incorrectly add Bambu Lab specific filaments instead, since some are named like "Generic PLA" vs the "Generic PLA @\System" for the truly generic profile. Fixes #12297 Fixes #12922 - Sometimes, when there is only 1 item in a sub-dropdown, the sub-dropdown does not show - In the dropdown code, there is a shortcut to return the hover_item index directly if the number of items shown is equal to the number of items in the combobox. However, for groups containing only 1 item, the grouping is incorrectly counted as an item itself, causing the subdropdown to not render. I will note that I saw cases where 1 item dropdowns rendered correctly, and think it was likely due to the presence of OTHER groups that contained more than 1 item (thus causing the dropdown to skip that shortcut). Bug: <img width="597" height="576" alt="image" src="https://github.com/user-attachments/assets/a667d693-d406-457f-9433-cfa13bb84338" /> Fixed: <img width="546" height="451" alt="image" src="https://github.com/user-attachments/assets/0fdc0233-4bee-411e-8336-aa4a9d4a0716" /> ## Tests Checking that the selected filaments remain selected in the dialog #### Creality K1C tests - Added Creality K1C on initial setup, cleared filament selection, and only selected Generic CoPE - Added Generic ABS and Creality Generic ABS (one displays as "ABS" and the other as "Creality Generic ABS" in the subgroup - Added a few other ABS filaments from non-generic vendors - Removed all but Creality Generic ABS - Removed Creality Generic ABS and added all Generic vendor filaments

MrUnknownDE added the bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix labels 2026-04-05 16:18:21 +02:00

Sign in to join this conversation.

No Label bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#74