Fix missing infill layers (fill_surface_by_multilines & fill_surface_trapezoidal bug fix) #560

New Issue

MrUnknownDE · 2026-04-05T16:22:50+02:00

MrUnknownDE commented

2026-04-05 16:22:50 +02:00

Originally created by @RF47 on 2/27/2026

Description

Problem
When generating rectilinear infill, the surface is contracted by half the line width to avoid excessive overlap with perimeters. This contraction can cause the original ExPolygon to split into multiple separate Polygons. The previous code incorrectly handled this case by:

5c07cb5c39/src/libslic3r/Fill/FillRectilinear.cpp (L3026-L3027)

This returns only the first polygon of the vector, which is why some sectors are left without infill lines.
I used the overloads that accept ExPolygons as an argument to avoid this problem.

Before:

After:

Fix #12510

*Originally created by @RF47 on 2/27/2026* # Description Problem When generating rectilinear infill, the surface is contracted by half the line width to avoid excessive overlap with perimeters. This contraction can cause the original ExPolygon to split into multiple separate Polygons. The previous code incorrectly handled this case by: https://github.com/OrcaSlicer/OrcaSlicer/blob/5c07cb5c397c5d3c973103eb1d3bdbf0fb11f844/src/libslic3r/Fill/FillRectilinear.cpp#L3026-L3027 This returns only the first polygon of the vector, which is why some sectors are left without infill lines. I used the overloads that accept ExPolygons as an argument to avoid this problem. # Before: <img width="1749" height="1017" alt="image" src="https://github.com/user-attachments/assets/b3f23b7a-4d55-4e2c-9ef6-b0a9c19bf9ea" /> <img width="2560" height="1392" alt="image" src="https://github.com/user-attachments/assets/2d79c6a8-570d-4a1c-a6a7-9e0577f80461" /> # After: <img width="2560" height="1392" alt="image" src="https://github.com/user-attachments/assets/72ecb561-cce2-44f2-b0d0-e37788f01a19" /> <img width="2560" height="1392" alt="image" src="https://github.com/user-attachments/assets/4b459037-1385-4d4b-a03a-62d9e091a80c" /> Fix #12510

MrUnknownDE closed this issue

2026-04-05 16:22:50 +02:00

MrUnknownDE added the bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix labels 2026-04-05 16:22:50 +02:00

Sign in to join this conversation.

No Label bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#560