fix: round flush_volumes_matrix values to integers #413

New Issue

MrUnknownDE · 2026-04-05T16:20:43+02:00

MrUnknownDE commented

2026-04-05 16:20:43 +02:00

Originally created by @folofse on 3/7/2026

Summary

Round flush_volumes_matrix values to integers after multiplying by flush_multiplier
Fixes compatibility with Creality K2 and potentially other Klipper-based printers

Problem

When flush_multiplier (default 1.3) is applied to flush_volumes_matrix values, the result can be a decimal (e.g., 272 * 1.3 = 353.6).

The Creality K2's metadata parser (metadata.py) crashes when parsing these decimal values in the G-code CONFIG_BLOCK, causing:

metadata.py exits with code 255
gcode_metadata becomes empty {}
gcode_start_byte is not set
Print gets stuck at "File selected" and never starts

Root Cause

In GCode.cpp:5405, the flush volumes are multiplied by the flush multiplier without rounding:

return inputx * temp_cfg_flush_multiplier_idx;  // Can produce 353.6

Solution

Added std::round() to ensure integer values:

return std::round(inputx * temp_cfg_flush_multiplier_idx);  // Produces 354

Test plan

Verified that G-code with decimal flush_volumes_matrix values fails on Creality K2
Verified that G-code with integer flush_volumes_matrix values works on Creality K2
Build and verify the fix produces integer values in the CONFIG_BLOCK

Impact

This is a minimal, low-risk change that:

Only affects the serialized output in G-code comments
Does not affect actual print behavior (flush volumes are the same, just rounded)
Restores compatibility with firmware that expects integer values

🤖 Generated with Claude Code

*Originally created by @folofse on 3/7/2026* ## Summary - Round `flush_volumes_matrix` values to integers after multiplying by `flush_multiplier` - Fixes compatibility with Creality K2 and potentially other Klipper-based printers ## Problem When `flush_multiplier` (default 1.3) is applied to `flush_volumes_matrix` values, the result can be a decimal (e.g., `272 * 1.3 = 353.6`). The Creality K2's metadata parser (`metadata.py`) crashes when parsing these decimal values in the G-code CONFIG_BLOCK, causing: - `metadata.py` exits with code 255 - `gcode_metadata` becomes empty `{}` - `gcode_start_byte` is not set - Print gets stuck at "File selected" and never starts ## Root Cause In `GCode.cpp:5405`, the flush volumes are multiplied by the flush multiplier without rounding: ```cpp return inputx * temp_cfg_flush_multiplier_idx; // Can produce 353.6 ``` ## Solution Added `std::round()` to ensure integer values: ```cpp return std::round(inputx * temp_cfg_flush_multiplier_idx); // Produces 354 ``` ## Test plan - [x] Verified that G-code with decimal `flush_volumes_matrix` values fails on Creality K2 - [x] Verified that G-code with integer `flush_volumes_matrix` values works on Creality K2 - [ ] Build and verify the fix produces integer values in the CONFIG_BLOCK ## Impact This is a minimal, low-risk change that: - Only affects the serialized output in G-code comments - Does not affect actual print behavior (flush volumes are the same, just rounded) - Restores compatibility with firmware that expects integer values 🤖 Generated with [Claude Code](https://claude.com/claude-code)

MrUnknownDE closed this issue

2026-04-05 16:20:43 +02:00

MrUnknownDE added the bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix labels 2026-04-05 16:20:43 +02:00

Sign in to join this conversation.

No Label bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix bug-fix

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#413