Refactor infill rotation #2319

New Issue

MrUnknownDE · 2026-04-06T03:57:39+02:00

MrUnknownDE commented

2026-04-06 03:57:39 +02:00

Originally created by @SoftFever on 8/31/2025

Description

This PR refactors the infill rotation system

Refactored the UX logic for handling infill rotations. Now, "Sparse infill direction" and "Sparse infill rotation template" are mutually exclusive. When "Sparse infill rotation template" is used(non empty), both "Sparse infill direction" and the automatic 90-degree rotation logic (e.g., Line) are disabled.
Removed solid infill insertion-related code from the sparse infill rotation template, as it does not logically belong there. A new option should be created for this in the future. Additionally, the current implementation has issues because solid infill should not be inserted directly above sparse infill.
It will be addressed in another PR
Refactored the overall infill rotation logic to improve code quality and clarity.

This also fixes bug #10469.

Screenshots/Recordings/Graphs

Tests

Are you sure you want to enable this option?

*Originally created by @SoftFever on 8/31/2025* # Description This PR refactors the infill rotation system 1. Refactored the UX logic for handling infill rotations. Now, "Sparse infill direction" and "Sparse infill rotation template" are mutually exclusive. When "Sparse infill rotation template" is used(non empty), both "Sparse infill direction" and the automatic 90-degree rotation logic (e.g., Line) are disabled. 2. Removed solid infill insertion-related code from the sparse infill rotation template, as it does not logically belong there. A new option should be created for this in the future. Additionally, the current implementation has issues because solid infill should not be inserted directly above sparse infill. It will be addressed in another PR 4. Refactored the overall infill rotation logic to improve code quality and clarity. This also fixes bug #10469. # Screenshots/Recordings/Graphs  ## Tests  Are you sure you want to enable this option?

MrUnknownDE closed this issue

2026-04-06 03:57:39 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#2319