Fix AMS Material Selection to sort by both filament vendor and type #1717

New Issue

MrUnknownDE · 2026-04-05T19:23:36+02:00

MrUnknownDE commented

2026-04-05 19:23:36 +02:00

Originally created by @ansonl on 11/4/2025

Description

_collect_filament_info() in AMSMaterialsSetting.cpp was assigning both filament vendor and type to query_filament_vendors map so that the filament was only being sorted by type which led to a case where Bambu options where shown before and after other vendors' options.

Screenshots/Recordings/Graphs

Old incorrect sorting

New correct sorting - It's not entirely alphabetically because Bambu has promoted certain vendor+type combinations to the top

Tests

Verified correct sorting by running OrcaSlicer and viewing the combobox in the AMS Material Selection window

*Originally created by @ansonl on 11/4/2025* # Description `_collect_filament_info()` in `AMSMaterialsSetting.cpp` was assigning both filament vendor and type to `query_filament_vendors` map so that the filament was only being sorted by type which led to a case where Bambu options where shown before and after other vendors' options. # Screenshots/Recordings/Graphs _Old incorrect sorting_ <img width="860" height="865" alt="image" src="https://github.com/user-attachments/assets/02d3d01e-758f-4039-afde-d6deb03d3f5b" /> _New correct sorting_ - It's not entirely alphabetically because Bambu has promoted certain vendor+type combinations to the top <img width="870" height="865" alt="image" src="https://github.com/user-attachments/assets/89f087be-da78-458f-af29-a0e8e9df0055" /> ## Tests Verified correct sorting by running OrcaSlicer and viewing the combobox in the AMS Material Selection window

MrUnknownDE closed this issue

2026-04-05 19:23:36 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#1717