Update eigen to v5.0.1 and libigl to v2.6.0. #1671

New Issue

MrUnknownDE · 2026-04-05T19:03:44+02:00

MrUnknownDE commented

2026-04-05 19:03:44 +02:00

Originally created by @dbaarda on 11/9/2025

Update eigen to v5.0.1 and libigl to v2.6.0

This updates the included eigen and libigl dependencies to the latest upstream releases. The current included versions are over 7 years old, and there have been a large number of bug-fixes, optimisations, and improvements in the upstream versions since.

This updates eigen from v3.3.7 released on December 11, 2018-12-11 to v5.0.1 released on 2025-11-11. There have be a large number of bug-fixes, optimizations, and improvements between these releases. See the details at;

https://gitlab.com/libeigen/eigen/-/releases

This updates libigl from what was probably v2.0.0 released on 2018-10-16 to v2.6.0 released on 2025-05-15. It's possible the old version was even older, but there is no version indicators in the code and I ran out of patience identifying missing changes and only went back as far as v2.0.0. There have been a large number of bug-fixes, optimizations, and improvements between these versions. See the following for details;

https://github.com/libigl/libigl/releases

For both updates I retained the existing minimal custom CMakeLists.txt, added the updated README.md from the upstream releases, and added a README-OrcaSlicer.md that details the version and parts of the upstream releases that have been included. In both cases only the required headers have been included, and all the tests, utils, docs, etc have been stripped out.

Originally I was only going to update eigen because I have some other upcoming PRs will need some recent features in eigen. However, the currently included old libigl used a deprecated eigen SparseMatrix feature that has since been removed. Fortunately the most recent libigl release included fixes that migrated to the newer replacement feature in eigen.

Despite the huge number of fixes, optimisations, and improvements in the upstream releases, only one change in libigl required fixes to libslic3r to make OrcaSlicer compile and work. In the recent version of libigl, igl::Hit has changed to a template taking the Scalar type to use. Previously it was hardcoded to use float, so I've updated all uses from igl::Hit to igl::Hit<float>.

Since originally submitting this PR, another change has gone in that required fixing for the new version of libigl.

In PR #12150 changes to the old versions of deps_src/libigl/igl/loop.{h,cpp} were included. To avoid requiring any modifications to the new upstream dependencies, this PR includes the new upstream versions of these files without any of the changes in #12150, and instead fixes src/libslic3r/TriangleMeshDeal.cpp to work with the unmodified upstream libigl. These fixes also simplified and optimized it, removing lots of redundant copying and casting. It also removed some unnecessary mesh validation checking.

Tests

A diff of the full test output generated by ctest --test-dir build/tests between current main and this PR is;

diff --git 1/main-LastTest.out 2/upd-eigen-5.0.1-LastTest.out
index a24e0c4ac8..2681ed019f 100644
--- 1/main-LastTest.out
+++ 2/upd-eigen-5.0.1-LastTest.out
@@ -49,7 +49,7 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests
         Start  24: libslic3r: Scenario: Reading 3mf file
  24/142 Test  #24: libslic3r: Scenario: Reading 3mf file ..................................................   Passed    0.01 sec
         Start  25: libslic3r: Scenario: Export+Import geometry to/from 3mf file cycle
- 25/142 Test  #25: libslic3r: Scenario: Export+Import geometry to/from 3mf file cycle .....................   Passed    0.02 sec
+ 25/142 Test  #25: libslic3r: Scenario: Export+Import geometry to/from 3mf file cycle .....................   Passed    0.01 sec
         Start  26: libslic3r: Scenario: 2D convex hull of sinking object
  26/142 Test  #26: libslic3r: Scenario: 2D convex hull of sinking object ..................................***Failed    0.01 sec
         Start  27: libslic3r: Building a tree over a box, ray caster and closest query
@@ -65,13 +65,13 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests
         Start  32: libslic3r: Scenario: Generic config validation performs as expected.
  32/142 Test  #32: libslic3r: Scenario: Generic config validation performs as expected. ...................***Failed    0.01 sec
         Start  33: libslic3r: Scenario: Config accessor functions perform as expected.
- 33/142 Test  #33: libslic3r: Scenario: Config accessor functions perform as expected. ....................***Exception: SegFault  0.11 sec
+ 33/142 Test  #33: libslic3r: Scenario: Config accessor functions perform as expected. ....................***Exception: SegFault  0.15 sec
         Start  34: libslic3r: Scenario: Config ini load/save interface
  34/142 Test  #34: libslic3r: Scenario: Config ini load/save interface ....................................   Passed    0.01 sec
         Start  35: libslic3r: Scenario: DynamicPrintConfig serialization
  35/142 Test  #35: libslic3r: Scenario: DynamicPrintConfig serialization ..................................***Failed    0.01 sec
         Start  36: libslic3r: Scenario: Elephant foot compensation
- 36/142 Test  #36: libslic3r: Scenario: Elephant foot compensation ........................................   Passed    0.02 sec
+ 36/142 Test  #36: libslic3r: Scenario: Elephant foot compensation ........................................   Passed    0.03 sec
         Start  37: libslic3r: Line::parallel_to
  37/142 Test  #37: libslic3r: Line::parallel_to ...........................................................   Passed    0.01 sec
         Start  38: libslic3r: Line::perpendicular_to
@@ -97,11 +97,11 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests
         Start  48: libslic3r: Scenario: Path chaining
  48/142 Test  #48: libslic3r: Scenario: Path chaining .....................................................   Passed    0.01 sec
         Start  49: libslic3r: Scenario: Line distances
- 49/142 Test  #49: libslic3r: Scenario: Line distances ....................................................   Passed    0.02 sec
+ 49/142 Test  #49: libslic3r: Scenario: Line distances ....................................................   Passed    0.01 sec
         Start  50: libslic3r: Scenario: Polygon convex/concave detection
- 50/142 Test  #50: libslic3r: Scenario: Polygon convex/concave detection ..................................***Failed    0.02 sec
+ 50/142 Test  #50: libslic3r: Scenario: Polygon convex/concave detection ..................................***Failed    0.01 sec
         Start  51: libslic3r: Triangle Simplification does not result in less than 3 points
- 51/142 Test  #51: libslic3r: Triangle Simplification does not result in less than 3 points ...............   Passed    0.02 sec
+ 51/142 Test  #51: libslic3r: Triangle Simplification does not result in less than 3 points ...............   Passed    0.01 sec
         Start  52: libslic3r: Scenario: Ported from xs/t/14_geometry.t
  52/142 Test  #52: libslic3r: Scenario: Ported from xs/t/14_geometry.t ....................................   Passed    0.01 sec
         Start  53: libslic3r: Convex polygon intersection on two disjoint squares
@@ -115,9 +115,9 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests
         Start  57: libslic3r: Convex polygon intersection on two overlapping squares
  57/142 Test  #57: libslic3r: Convex polygon intersection on two overlapping squares ......................   Passed    0.01 sec
         Start  58: libslic3r: Convex polygon intersection test prusa polygons
- 58/142 Test  #58: libslic3r: Convex polygon intersection test prusa polygons .............................   Passed    0.01 sec
+ 58/142 Test  #58: libslic3r: Convex polygon intersection test prusa polygons .............................   Passed    0.02 sec
         Start  59: libslic3r: Scenario: Placeholder parser scripting
- 59/142 Test  #59: libslic3r: Scenario: Placeholder parser scripting ......................................***Exception: SegFault  0.14 sec
+ 59/142 Test  #59: libslic3r: Scenario: Placeholder parser scripting ......................................***Exception: SegFault  0.12 sec
         Start  60: libslic3r: Scenario: Converted Perl tests
  60/142 Test  #60: libslic3r: Scenario: Converted Perl tests ..............................................   Passed    0.01 sec
         Start  61: libslic3r: Centroid of Trapezoid must be inside
@@ -161,9 +161,9 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests
         Start  80: libslic3r: Recreate object from rasters
  80/142 Test  #80: libslic3r: Recreate object from rasters ................................................   Passed    0.64 sec
         Start  81: libslic3r: Benchmark gyroid cube period 10.0mm
- 81/142 Test  #81: libslic3r: Benchmark gyroid cube period 10.0mm .........................................   Passed    2.48 sec
+ 81/142 Test  #81: libslic3r: Benchmark gyroid cube period 10.0mm .........................................   Passed    2.37 sec
         Start  82: libslic3r: Benchmark gyroid cube period 5.0mm
- 82/142 Test  #82: libslic3r: Benchmark gyroid cube period 5.0mm ..........................................   Passed    2.63 sec
+ 82/142 Test  #82: libslic3r: Benchmark gyroid cube period 5.0mm ..........................................   Passed    2.42 sec
         Start  83: libslic3r: ISO8601Z
  83/142 Test  #83: libslic3r: ISO8601Z ....................................................................   Passed    0.01 sec
         Start  84: libslic3r: Slic3r_UTC_Time_Format
@@ -185,7 +185,7 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests
         Start  92: libslic3r: Voronoi offset with edge collapse
  92/142 Test  #92: libslic3r: Voronoi offset with edge collapse ...........................................   Passed    0.02 sec
         Start  93: libslic3r: Voronoi offset 5
- 93/142 Test  #93: libslic3r: Voronoi offset 5 ............................................................   Passed    0.01 sec
+ 93/142 Test  #93: libslic3r: Voronoi offset 5 ............................................................   Passed    0.02 sec
         Start  94: libslic3r: Voronoi skeleton
  94/142 Test  #94: libslic3r: Voronoi skeleton ............................................................   Passed    0.01 sec
         Start  95: libslic3r: Voronoi missing vertex 1
@@ -219,13 +219,13 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests
         Start 109: libslic3r: Simplified cube should not be empty.
 109/142 Test #109: libslic3r: Simplified cube should not be empty. ........................................   Passed    0.01 sec
         Start 110: libslic3r: Hollow two overlapping spheres
-110/142 Test #110: libslic3r: Hollow two overlapping spheres ..............................................   Passed    1.08 sec
+110/142 Test #110: libslic3r: Hollow two overlapping spheres ..............................................   Passed    1.05 sec
         Start 111: slic3rutils: Check SSL certificates paths
-111/142 Test #111: slic3rutils: Check SSL certificates paths ..............................................   Passed    0.12 sec
+111/142 Test #111: slic3rutils: Check SSL certificates paths ..............................................   Passed    0.11 sec
         Start 112: slic3rutils: Http digest authentication
-112/142 Test #112: slic3rutils: Http digest authentication ................................................   Passed    0.46 sec
+112/142 Test #112: slic3rutils: Http digest authentication ................................................   Passed    0.40 sec
         Start 113: slic3rutils: Http basic authentication
-113/142 Test #113: slic3rutils: Http basic authentication .................................................   Passed    0.38 sec
+113/142 Test #113: slic3rutils: Http basic authentication .................................................   Passed    0.36 sec
         Start 114: fff_print: Scenario: init_print functionality
 114/142 Test #114: fff_print: Scenario: init_print functionality ..........................................***Failed    0.02 sec
         Start 115: fff_print: Scenario: ExtrusionEntityCollection: Polygon flattening
@@ -257,15 +257,15 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests
         Start 128: fff_print: surfaces to become internal.
 128/142 Test #128: fff_print: surfaces to become internal. ................................................   Passed    0.01 sec
         Start 129: fff_print: Scenario: Print: Brim generation
-129/142 Test #129: fff_print: Scenario: Print: Brim generation ............................................***Failed    0.01 sec
+129/142 Test #129: fff_print: Scenario: Print: Brim generation ............................................***Failed    0.02 sec
         Start 130: fff_print: Scenario: PrintGCode basic functionality
-130/142 Test #130: fff_print: Scenario: PrintGCode basic functionality ....................................***Failed    0.02 sec
+130/142 Test #130: fff_print: Scenario: PrintGCode basic functionality ....................................***Failed    0.01 sec
         Start 131: fff_print: Scenario: PrintObject: object layer heights
 131/142 Test #131: fff_print: Scenario: PrintObject: object layer heights .................................***Failed    0.01 sec
         Start 132: fff_print: Skirt height is honored
-132/142 Test #132: fff_print: Skirt height is honored .....................................................***Exception: SegFault  0.16 sec
+132/142 Test #132: fff_print: Skirt height is honored .....................................................***Exception: SegFault  0.13 sec
         Start 133: fff_print: Scenario: Original Slic3r Skirt/Brim tests
-133/142 Test #133: fff_print: Scenario: Original Slic3r Skirt/Brim tests ..................................***Failed    0.01 sec
+133/142 Test #133: fff_print: Scenario: Original Slic3r Skirt/Brim tests ..................................***Failed    0.02 sec
         Start 134: fff_print: SupportMaterial: Three raft layers created
 134/142 Test #134: fff_print: SupportMaterial: Three raft layers created ..................................***Failed    0.01 sec
         Start 135: fff_print: Scenario: SupportMaterial: support_layers_z and contact_distance
@@ -290,52 +290,52 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests
 Label Time Summary:
 [3mf]                             =   0.04 sec*proc (3 tests)
 [AABBIndirect]                    =   0.01 sec*proc (1 test)
-[ClipperUtils]                    =   0.05 sec*proc (4 tests)
-[Config]                          =   0.14 sec*proc (4 tests)
-[ElephantFoot]                    =   0.02 sec*proc (1 test)
+[ClipperUtils]                    =   0.04 sec*proc (4 tests)
+[Config]                          =   0.18 sec*proc (4 tests)
+[ElephantFoot]                    =   0.03 sec*proc (1 test)
 [ExtrusionEntity]                 =   0.01 sec*proc (1 test)
 [Fill]                            =   0.02 sec*proc (1 test)
 [Flow]                            =   0.04 sec*proc (4 tests)
 [GCodeWriter]                     =   0.02 sec*proc (2 tests)
 [GCode]                           =   0.01 sec*proc (1 test)
-[Geometry]                        =   0.30 sec*proc (33 tests)
-[Http]                            =   0.97 sec*proc (3 tests)
-[MarchingSquares]                 =   5.20 sec*proc (9 tests)
+[Geometry]                        =   0.29 sec*proc (33 tests)
+[Http]                            =   0.87 sec*proc (3 tests)
+[MarchingSquares]                 =   4.89 sec*proc (9 tests)
 [MeshBoolean]                     =   0.03 sec*proc (1 test)
 [Model]                           =   0.01 sec*proc (1 test)
-[MutablePolygon]                  =   0.04 sec*proc (3 tests)
-[MutableSkipHeapPriorityQueue]    =   0.07 sec*proc (5 tests)
+[MutablePolygon]                  =   0.03 sec*proc (3 tests)
+[MutableSkipHeapPriorityQueue]    =   0.06 sec*proc (5 tests)
 [NestKernels]                     =   0.01 sec*proc (2 tests)
 [Nesting]                         =   0.03 sec*proc (9 tests)
-[NotWorking]                      =   0.98 sec*proc (5 tests)
+[NotWorking]                      =   0.88 sec*proc (5 tests)
 [Opt]                             =   0.01 sec*proc (1 test)
-[PlaceholderParser]               =   0.14 sec*proc (1 test)
-[Polygon]                         =   0.04 sec*proc (3 tests)
-[PrintGCode]                      =   0.02 sec*proc (1 test)
+[PlaceholderParser]               =   0.12 sec*proc (1 test)
+[Polygon]                         =   0.03 sec*proc (3 tests)
+[PrintGCode]                      =   0.01 sec*proc (1 test)
 [PrintObject]                     =   0.02 sec*proc (2 tests)
-[Print]                           =   0.04 sec*proc (3 tests)
+[Print]                           =   0.03 sec*proc (3 tests)
 [Rotcalip]                        =   0.07 sec*proc (6 tests)
 [SL1Import]                       =   0.64 sec*proc (1 test)
-[SkirtBrim]                       =   0.01 sec*proc (1 test)
-[Skirt]                           =   0.16 sec*proc (1 test)
-[SupportMaterial]                 =   0.02 sec*proc (2 tests)
-[Timeutils]                       =   0.03 sec*proc (2 tests)
+[SkirtBrim]                       =   0.02 sec*proc (1 test)
+[Skirt]                           =   0.13 sec*proc (1 test)
+[SupportMaterial]                 =   0.03 sec*proc (2 tests)
+[Timeutils]                       =   0.02 sec*proc (2 tests)
 [Utils]                           =   0.01 sec*proc (1 test)
 [VoronoiMissingVertex1]           =   0.01 sec*proc (1 test)
 [VoronoiMissingVertex2]           =   0.01 sec*proc (1 test)
 [VoronoiMissingVertex3]           =   0.01 sec*proc (1 test)
 [VoronoiOffset4]                  =   0.02 sec*proc (1 test)
-[VoronoiOffset5]                  =   0.01 sec*proc (1 test)
-[VoronoiOffset]                   =   0.03 sec*proc (3 tests)
+[VoronoiOffset5]                  =   0.02 sec*proc (1 test)
+[VoronoiOffset]                   =   0.04 sec*proc (3 tests)
 [VoronoiSkeleton]                 =   0.01 sec*proc (1 test)
-[Voronoi]                         =   0.06 sec*proc (6 tests)
-[its]                             =   0.15 sec*proc (9 tests)
+[Voronoi]                         =   0.07 sec*proc (6 tests)
+[its]                             =   0.16 sec*proc (9 tests)
 [its_split]                       =   0.06 sec*proc (5 tests)
 [stl]                             =   0.01 sec*proc (1 test)
 [test_data]                       =   0.02 sec*proc (1 test)
 [utils]                           =   0.02 sec*proc (2 tests)
 
-Total Test time (real) =   9.76 sec
+Total Test time (real) =   9.30 sec
 
 The following tests FAILED:
 	  8 - libnest2d: ArrangeRectanglesTight (Failed)        [Nesting] [NotWorking]

Note that the only failing tests are the ones that fail for the current main, and the Total Test time dropped from 9.76sec to 9.30sec.

Additionally I have compiled and run OrcaSlicer with this PR and it appears to be working fine with no identifiable issues.

*Originally created by @dbaarda on 11/9/2025* # Update eigen to v5.0.1 and libigl to v2.6.0 This updates the included eigen and libigl dependencies to the latest upstream releases. The current included versions are over 7 years old, and there have been a large number of bug-fixes, optimisations, and improvements in the upstream versions since. This updates eigen from v3.3.7 released on December 11, 2018-12-11 to v5.0.1 released on 2025-11-11. There have be a large number of bug-fixes, optimizations, and improvements between these releases. See the details at; * https://gitlab.com/libeigen/eigen/-/releases This updates libigl from what was probably v2.0.0 released on 2018-10-16 to v2.6.0 released on 2025-05-15. It's possible the old version was even older, but there is no version indicators in the code and I ran out of patience identifying missing changes and only went back as far as v2.0.0. There have been a large number of bug-fixes, optimizations, and improvements between these versions. See the following for details; * https://github.com/libigl/libigl/releases For both updates I retained the existing minimal custom `CMakeLists.txt`, added the updated `README.md` from the upstream releases, and added a README-OrcaSlicer.md that details the version and parts of the upstream releases that have been included. In both cases only the required headers have been included, and all the tests, utils, docs, etc have been stripped out. Originally I was only going to update eigen because I have some other upcoming PRs will need some recent features in eigen. However, the currently included old libigl used a deprecated eigen SparseMatrix feature that has since been removed. Fortunately the most recent libigl release included fixes that migrated to the newer replacement feature in eigen. Despite the huge number of fixes, optimisations, and improvements in the upstream releases, only one change in libigl required fixes to libslic3r to make OrcaSlicer compile and work. In the recent version of libigl, `igl::Hit` has changed to a template taking the Scalar type to use. Previously it was hardcoded to use `float`, so I've updated all uses from `igl::Hit` to `igl::Hit<float>`. Since originally submitting this PR, another change has gone in that required fixing for the new version of libigl. In PR #12150 changes to the old versions of `deps_src/libigl/igl/loop.{h,cpp}` were included. To avoid requiring any modifications to the new upstream dependencies, this PR includes the new upstream versions of these files without any of the changes in #12150, and instead fixes `src/libslic3r/TriangleMeshDeal.cpp` to work with the unmodified upstream libigl. These fixes also simplified and optimized it, removing lots of redundant copying and casting. It also removed some unnecessary mesh validation checking. ## Tests A diff of the full test output generated by `ctest --test-dir build/tests` between current `main` and this PR is; ```diff diff --git 1/main-LastTest.out 2/upd-eigen-5.0.1-LastTest.out index a24e0c4ac8..2681ed019f 100644 --- 1/main-LastTest.out +++ 2/upd-eigen-5.0.1-LastTest.out @@ -49,7 +49,7 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests Start 24: libslic3r: Scenario: Reading 3mf file 24/142 Test #24: libslic3r: Scenario: Reading 3mf file .................................................. Passed 0.01 sec Start 25: libslic3r: Scenario: Export+Import geometry to/from 3mf file cycle - 25/142 Test #25: libslic3r: Scenario: Export+Import geometry to/from 3mf file cycle ..................... Passed 0.02 sec + 25/142 Test #25: libslic3r: Scenario: Export+Import geometry to/from 3mf file cycle ..................... Passed 0.01 sec Start 26: libslic3r: Scenario: 2D convex hull of sinking object 26/142 Test #26: libslic3r: Scenario: 2D convex hull of sinking object ..................................***Failed 0.01 sec Start 27: libslic3r: Building a tree over a box, ray caster and closest query @@ -65,13 +65,13 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests Start 32: libslic3r: Scenario: Generic config validation performs as expected. 32/142 Test #32: libslic3r: Scenario: Generic config validation performs as expected. ...................***Failed 0.01 sec Start 33: libslic3r: Scenario: Config accessor functions perform as expected. - 33/142 Test #33: libslic3r: Scenario: Config accessor functions perform as expected. ....................***Exception: SegFault 0.11 sec + 33/142 Test #33: libslic3r: Scenario: Config accessor functions perform as expected. ....................***Exception: SegFault 0.15 sec Start 34: libslic3r: Scenario: Config ini load/save interface 34/142 Test #34: libslic3r: Scenario: Config ini load/save interface .................................... Passed 0.01 sec Start 35: libslic3r: Scenario: DynamicPrintConfig serialization 35/142 Test #35: libslic3r: Scenario: DynamicPrintConfig serialization ..................................***Failed 0.01 sec Start 36: libslic3r: Scenario: Elephant foot compensation - 36/142 Test #36: libslic3r: Scenario: Elephant foot compensation ........................................ Passed 0.02 sec + 36/142 Test #36: libslic3r: Scenario: Elephant foot compensation ........................................ Passed 0.03 sec Start 37: libslic3r: Line::parallel_to 37/142 Test #37: libslic3r: Line::parallel_to ........................................................... Passed 0.01 sec Start 38: libslic3r: Line::perpendicular_to @@ -97,11 +97,11 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests Start 48: libslic3r: Scenario: Path chaining 48/142 Test #48: libslic3r: Scenario: Path chaining ..................................................... Passed 0.01 sec Start 49: libslic3r: Scenario: Line distances - 49/142 Test #49: libslic3r: Scenario: Line distances .................................................... Passed 0.02 sec + 49/142 Test #49: libslic3r: Scenario: Line distances .................................................... Passed 0.01 sec Start 50: libslic3r: Scenario: Polygon convex/concave detection - 50/142 Test #50: libslic3r: Scenario: Polygon convex/concave detection ..................................***Failed 0.02 sec + 50/142 Test #50: libslic3r: Scenario: Polygon convex/concave detection ..................................***Failed 0.01 sec Start 51: libslic3r: Triangle Simplification does not result in less than 3 points - 51/142 Test #51: libslic3r: Triangle Simplification does not result in less than 3 points ............... Passed 0.02 sec + 51/142 Test #51: libslic3r: Triangle Simplification does not result in less than 3 points ............... Passed 0.01 sec Start 52: libslic3r: Scenario: Ported from xs/t/14_geometry.t 52/142 Test #52: libslic3r: Scenario: Ported from xs/t/14_geometry.t .................................... Passed 0.01 sec Start 53: libslic3r: Convex polygon intersection on two disjoint squares @@ -115,9 +115,9 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests Start 57: libslic3r: Convex polygon intersection on two overlapping squares 57/142 Test #57: libslic3r: Convex polygon intersection on two overlapping squares ...................... Passed 0.01 sec Start 58: libslic3r: Convex polygon intersection test prusa polygons - 58/142 Test #58: libslic3r: Convex polygon intersection test prusa polygons ............................. Passed 0.01 sec + 58/142 Test #58: libslic3r: Convex polygon intersection test prusa polygons ............................. Passed 0.02 sec Start 59: libslic3r: Scenario: Placeholder parser scripting - 59/142 Test #59: libslic3r: Scenario: Placeholder parser scripting ......................................***Exception: SegFault 0.14 sec + 59/142 Test #59: libslic3r: Scenario: Placeholder parser scripting ......................................***Exception: SegFault 0.12 sec Start 60: libslic3r: Scenario: Converted Perl tests 60/142 Test #60: libslic3r: Scenario: Converted Perl tests .............................................. Passed 0.01 sec Start 61: libslic3r: Centroid of Trapezoid must be inside @@ -161,9 +161,9 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests Start 80: libslic3r: Recreate object from rasters 80/142 Test #80: libslic3r: Recreate object from rasters ................................................ Passed 0.64 sec Start 81: libslic3r: Benchmark gyroid cube period 10.0mm - 81/142 Test #81: libslic3r: Benchmark gyroid cube period 10.0mm ......................................... Passed 2.48 sec + 81/142 Test #81: libslic3r: Benchmark gyroid cube period 10.0mm ......................................... Passed 2.37 sec Start 82: libslic3r: Benchmark gyroid cube period 5.0mm - 82/142 Test #82: libslic3r: Benchmark gyroid cube period 5.0mm .......................................... Passed 2.63 sec + 82/142 Test #82: libslic3r: Benchmark gyroid cube period 5.0mm .......................................... Passed 2.42 sec Start 83: libslic3r: ISO8601Z 83/142 Test #83: libslic3r: ISO8601Z .................................................................... Passed 0.01 sec Start 84: libslic3r: Slic3r_UTC_Time_Format @@ -185,7 +185,7 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests Start 92: libslic3r: Voronoi offset with edge collapse 92/142 Test #92: libslic3r: Voronoi offset with edge collapse ........................................... Passed 0.02 sec Start 93: libslic3r: Voronoi offset 5 - 93/142 Test #93: libslic3r: Voronoi offset 5 ............................................................ Passed 0.01 sec + 93/142 Test #93: libslic3r: Voronoi offset 5 ............................................................ Passed 0.02 sec Start 94: libslic3r: Voronoi skeleton 94/142 Test #94: libslic3r: Voronoi skeleton ............................................................ Passed 0.01 sec Start 95: libslic3r: Voronoi missing vertex 1 @@ -219,13 +219,13 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests Start 109: libslic3r: Simplified cube should not be empty. 109/142 Test #109: libslic3r: Simplified cube should not be empty. ........................................ Passed 0.01 sec Start 110: libslic3r: Hollow two overlapping spheres -110/142 Test #110: libslic3r: Hollow two overlapping spheres .............................................. Passed 1.08 sec +110/142 Test #110: libslic3r: Hollow two overlapping spheres .............................................. Passed 1.05 sec Start 111: slic3rutils: Check SSL certificates paths -111/142 Test #111: slic3rutils: Check SSL certificates paths .............................................. Passed 0.12 sec +111/142 Test #111: slic3rutils: Check SSL certificates paths .............................................. Passed 0.11 sec Start 112: slic3rutils: Http digest authentication -112/142 Test #112: slic3rutils: Http digest authentication ................................................ Passed 0.46 sec +112/142 Test #112: slic3rutils: Http digest authentication ................................................ Passed 0.40 sec Start 113: slic3rutils: Http basic authentication -113/142 Test #113: slic3rutils: Http basic authentication ................................................. Passed 0.38 sec +113/142 Test #113: slic3rutils: Http basic authentication ................................................. Passed 0.36 sec Start 114: fff_print: Scenario: init_print functionality 114/142 Test #114: fff_print: Scenario: init_print functionality ..........................................***Failed 0.02 sec Start 115: fff_print: Scenario: ExtrusionEntityCollection: Polygon flattening @@ -257,15 +257,15 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests Start 128: fff_print: surfaces to become internal. 128/142 Test #128: fff_print: surfaces to become internal. ................................................ Passed 0.01 sec Start 129: fff_print: Scenario: Print: Brim generation -129/142 Test #129: fff_print: Scenario: Print: Brim generation ............................................***Failed 0.01 sec +129/142 Test #129: fff_print: Scenario: Print: Brim generation ............................................***Failed 0.02 sec Start 130: fff_print: Scenario: PrintGCode basic functionality -130/142 Test #130: fff_print: Scenario: PrintGCode basic functionality ....................................***Failed 0.02 sec +130/142 Test #130: fff_print: Scenario: PrintGCode basic functionality ....................................***Failed 0.01 sec Start 131: fff_print: Scenario: PrintObject: object layer heights 131/142 Test #131: fff_print: Scenario: PrintObject: object layer heights .................................***Failed 0.01 sec Start 132: fff_print: Skirt height is honored -132/142 Test #132: fff_print: Skirt height is honored .....................................................***Exception: SegFault 0.16 sec +132/142 Test #132: fff_print: Skirt height is honored .....................................................***Exception: SegFault 0.13 sec Start 133: fff_print: Scenario: Original Slic3r Skirt/Brim tests -133/142 Test #133: fff_print: Scenario: Original Slic3r Skirt/Brim tests ..................................***Failed 0.01 sec +133/142 Test #133: fff_print: Scenario: Original Slic3r Skirt/Brim tests ..................................***Failed 0.02 sec Start 134: fff_print: SupportMaterial: Three raft layers created 134/142 Test #134: fff_print: SupportMaterial: Three raft layers created ..................................***Failed 0.01 sec Start 135: fff_print: Scenario: SupportMaterial: support_layers_z and contact_distance @@ -290,52 +290,52 @@ Test project /home/dbaarda/src/OrcaSlicer/build/tests Label Time Summary: [3mf] = 0.04 sec*proc (3 tests) [AABBIndirect] = 0.01 sec*proc (1 test) -[ClipperUtils] = 0.05 sec*proc (4 tests) -[Config] = 0.14 sec*proc (4 tests) -[ElephantFoot] = 0.02 sec*proc (1 test) +[ClipperUtils] = 0.04 sec*proc (4 tests) +[Config] = 0.18 sec*proc (4 tests) +[ElephantFoot] = 0.03 sec*proc (1 test) [ExtrusionEntity] = 0.01 sec*proc (1 test) [Fill] = 0.02 sec*proc (1 test) [Flow] = 0.04 sec*proc (4 tests) [GCodeWriter] = 0.02 sec*proc (2 tests) [GCode] = 0.01 sec*proc (1 test) -[Geometry] = 0.30 sec*proc (33 tests) -[Http] = 0.97 sec*proc (3 tests) -[MarchingSquares] = 5.20 sec*proc (9 tests) +[Geometry] = 0.29 sec*proc (33 tests) +[Http] = 0.87 sec*proc (3 tests) +[MarchingSquares] = 4.89 sec*proc (9 tests) [MeshBoolean] = 0.03 sec*proc (1 test) [Model] = 0.01 sec*proc (1 test) -[MutablePolygon] = 0.04 sec*proc (3 tests) -[MutableSkipHeapPriorityQueue] = 0.07 sec*proc (5 tests) +[MutablePolygon] = 0.03 sec*proc (3 tests) +[MutableSkipHeapPriorityQueue] = 0.06 sec*proc (5 tests) [NestKernels] = 0.01 sec*proc (2 tests) [Nesting] = 0.03 sec*proc (9 tests) -[NotWorking] = 0.98 sec*proc (5 tests) +[NotWorking] = 0.88 sec*proc (5 tests) [Opt] = 0.01 sec*proc (1 test) -[PlaceholderParser] = 0.14 sec*proc (1 test) -[Polygon] = 0.04 sec*proc (3 tests) -[PrintGCode] = 0.02 sec*proc (1 test) +[PlaceholderParser] = 0.12 sec*proc (1 test) +[Polygon] = 0.03 sec*proc (3 tests) +[PrintGCode] = 0.01 sec*proc (1 test) [PrintObject] = 0.02 sec*proc (2 tests) -[Print] = 0.04 sec*proc (3 tests) +[Print] = 0.03 sec*proc (3 tests) [Rotcalip] = 0.07 sec*proc (6 tests) [SL1Import] = 0.64 sec*proc (1 test) -[SkirtBrim] = 0.01 sec*proc (1 test) -[Skirt] = 0.16 sec*proc (1 test) -[SupportMaterial] = 0.02 sec*proc (2 tests) -[Timeutils] = 0.03 sec*proc (2 tests) +[SkirtBrim] = 0.02 sec*proc (1 test) +[Skirt] = 0.13 sec*proc (1 test) +[SupportMaterial] = 0.03 sec*proc (2 tests) +[Timeutils] = 0.02 sec*proc (2 tests) [Utils] = 0.01 sec*proc (1 test) [VoronoiMissingVertex1] = 0.01 sec*proc (1 test) [VoronoiMissingVertex2] = 0.01 sec*proc (1 test) [VoronoiMissingVertex3] = 0.01 sec*proc (1 test) [VoronoiOffset4] = 0.02 sec*proc (1 test) -[VoronoiOffset5] = 0.01 sec*proc (1 test) -[VoronoiOffset] = 0.03 sec*proc (3 tests) +[VoronoiOffset5] = 0.02 sec*proc (1 test) +[VoronoiOffset] = 0.04 sec*proc (3 tests) [VoronoiSkeleton] = 0.01 sec*proc (1 test) -[Voronoi] = 0.06 sec*proc (6 tests) -[its] = 0.15 sec*proc (9 tests) +[Voronoi] = 0.07 sec*proc (6 tests) +[its] = 0.16 sec*proc (9 tests) [its_split] = 0.06 sec*proc (5 tests) [stl] = 0.01 sec*proc (1 test) [test_data] = 0.02 sec*proc (1 test) [utils] = 0.02 sec*proc (2 tests) -Total Test time (real) = 9.76 sec +Total Test time (real) = 9.30 sec The following tests FAILED: 8 - libnest2d: ArrangeRectanglesTight (Failed) [Nesting] [NotWorking] ``` Note that the only failing tests are the ones that fail for the current main, and the `Total Test time` dropped from 9.76sec to 9.30sec. Additionally I have compiled and run OrcaSlicer with this PR and it appears to be working fine with no identifiable issues.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#1671