Fix PrinterWebView only clear deferred url on success #1486

Open
opened 2026-04-05 18:00:03 +02:00 by MrUnknownDE · 0 comments
Owner

Originally created by @RobertKuszmar on 11/28/2025

Description

Previously PrinterWebView was clearing its deferred url right after trying to load it, whether loading was successful or not. For example, if the printer is turned off and device tab is opened, the load will fail. This change ensures that reopening the device tab after this happens will at least try to load the url again.

Screenshots/Recordings/Graphs

Tests

Test 1: Opening the device tab while the printer is turned on
Test 2: Opening the device tab while the printer is turned off, going to another tab, turning the printer on, returning to the device tab

*Originally created by @RobertKuszmar on 11/28/2025* # Description <!-- > Please provide a summary of the changes made in this PR. Include details such as: > * What issue does this PR address or fix? > * What new features or enhancements does this PR introduce? > * Are there any breaking changes or dependencies that need to be considered? --> Previously PrinterWebView was clearing its deferred url right after trying to load it, whether loading was successful or not. For example, if the printer is turned off and device tab is opened, the load will fail. This change ensures that reopening the device tab after this happens will at least try to load the url again. # Screenshots/Recordings/Graphs <!-- > Please attach relevant screenshots to showcase the UI changes. > Please attach images that can help explain the changes. --> ## Tests <!-- > Please describe the tests that you have conducted to verify the changes made in this PR. --> Test 1: Opening the device tab while the printer is turned on Test 2: Opening the device tab while the printer is turned off, going to another tab, turning the printer on, returning to the device tab
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github/OrcaSlicer#1486