Use single color for parameter & tab labels #1349

New Issue

MrUnknownDE · 2026-04-05T17:25:33+02:00

MrUnknownDE commented

2026-04-05 17:25:33 +02:00

Originally created by @yw4z on 12/16/2025

This PR simplified version of https://github.com/OrcaSlicer/OrcaSlicer/pull/9998
Result is same. didnt changed label colors on this one because i noticed few issues

WHY ITS NOT A ONE LINE FIX

• changing m_color_label_default in GUI_App break text colors on system wide. also some parts of code used wxSYS_COLOUR_WINDOWTEXT
• changes on m_tabctrl->SetItemTextColour() related with fixing tab colors after reset
• ((opt.second & osInitValue) != 0) condition eliminates system value check. normally it shows modified value as regular text color if its matches with inherited preset

REMOVED DIFFERENT COLOR USAGES FOR SYSTEM / USER VALUES

system is works same under the hood but i matched colors and added few lines. this kept changes simpler

BEFORE - labels has brighter color if they matches with inherited preset value

AFTER - all labels uses same color

Tab colors has same feature. also removed this. related issue is here https://github.com/SoftFever/OrcaSlicer/issues/9985
BEFORE - labels has brigher color if they are different then system value
all labels uses brighter color except multimaterial & support because user didnt changed any value
but this looks like an UI bug because hard to figure out why

AFTER - all labels uses same color

BEFORE - Labels uses different color if value matches with inherited preset value. 2 user value , 3 system value (label is not orange with it)

AFTER - Color usage stays consistent. Labels only uses modified or default color

FIXES WRONG TAB COLORS AFTER USING RESET

• Tab colors broken after using "reset all settings" button
BEFORE

AFTER

*Originally created by @yw4z on 12/16/2025* This PR simplified version of https://github.com/OrcaSlicer/OrcaSlicer/pull/9998 Result is same. didnt changed label colors on this one because i noticed few issues ### WHY ITS NOT A ONE LINE FIX • changing m_color_label_default in GUI_App break text colors on system wide. also some parts of code used wxSYS_COLOUR_WINDOWTEXT • changes on m_tabctrl->SetItemTextColour() related with fixing tab colors after reset • ((opt.second & osInitValue) != 0) condition eliminates system value check. normally it shows modified value as regular text color if its matches with inherited preset ### REMOVED DIFFERENT COLOR USAGES FOR SYSTEM / USER VALUES system is works same under the hood but i matched colors and added few lines. this kept changes simpler BEFORE - labels has brighter color if they matches with inherited preset value <img width="366" height="278" alt="Screenshot-20250823222955" src="https://github.com/user-attachments/assets/d9b40d79-eb91-4a1e-b121-f53a6aa469df" /> AFTER - all labels uses same color <img width="349" height="281" alt="Screenshot-20250823223010" src="https://github.com/user-attachments/assets/9d00995c-c614-400a-b8e7-6f85d392c174" /> Tab colors has same feature. also removed this. related issue is here https://github.com/SoftFever/OrcaSlicer/issues/9985 BEFORE - labels has brigher color if they are different then system value all labels uses brighter color except multimaterial & support because user didnt changed any value but this looks like an UI bug because hard to figure out why <img width="471" height="210" alt="Screenshot-20250823223411" src="https://github.com/user-attachments/assets/5a8b485d-0467-496c-96fe-98e1d9fc0c57" /> AFTER - all labels uses same color BEFORE - Labels uses different color if value matches with inherited preset value. 2 user value , 3 system value (label is not orange with it) ![orca-slicer_xiGgWJyxB0](https://github.com/user-attachments/assets/133b711b-4b73-454e-9a5e-7b34711133cd) AFTER - Color usage stays consistent. Labels only uses modified or default color ![orca-slicer_D8JAs44AZw](https://github.com/user-attachments/assets/84628b7a-b898-4e5a-b58b-4e0c04b0345b) ### FIXES WRONG TAB COLORS AFTER USING RESET • Tab colors broken after using "reset all settings" button BEFORE ![orca-slicer_YhVRS7To05](https://github.com/user-attachments/assets/e3eefa3e-48e4-4d2e-8f2d-27de48684fad) AFTER ![orca-slicer_KEHOgYKGDj](https://github.com/user-attachments/assets/b7b5a425-1f89-4f79-8d39-dbb19e3d7444)

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#1349