Revert "ENH: add eager lift function" #1329

New Issue

MrUnknownDE · 2026-04-05T17:21:54+02:00

MrUnknownDE commented

2026-04-05 17:21:54 +02:00

Originally created by @Thynix on 12/18/2025

This reverts commit 21399999f1, which introduced a regression that added little travel circles to corners.

Description

This fixes #11677; I don't know whether people rely on this behavior. It does seem like part of it is probably desirable otherwise why do it, it just wasn't evident to me what was causing the undesirable part. (It also by necessity reverts the separate build fix where the eager_lift broke tests.)

Screenshots/Recordings/Graphs

Lack of circle travel moves:

Tests

I sliced the example in the issue with this build and it didn't have the circle travels.

*Originally created by @Thynix on 12/18/2025* This reverts commit 21399999f1ef5359e124568422cea80595562e98, which introduced a regression that added little travel circles to corners. # Description This fixes #11677; I don't know whether people rely on this behavior. It does seem like part of it is probably desirable otherwise why do it, it just wasn't evident to me what was causing the undesirable part. (It also by necessity reverts the separate build fix where the `eager_lift` broke tests.)  # Screenshots/Recordings/Graphs  Lack of circle travel moves: <img width="3840" height="2076" alt="image" src="https://github.com/user-attachments/assets/d7f66f19-3421-46d8-be25-386e016c9d18" /> ## Tests  I sliced the example in the issue with this build and it didn't have the circle travels.

MrUnknownDE closed this issue

2026-04-05 17:21:54 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#1329