Fix filament preset undo tracking #1315

New Issue

MrUnknownDE · 2026-04-05T17:19:17+02:00

MrUnknownDE commented

2026-04-05 17:19:17 +02:00

Originally created by @kisslorand on 12/20/2025

This PR fixes filament preset undo behavior so edited values reliably revert immediately, without needing a tab switch or any other refresh workaround.

What was wrong
Some filament settings showed no local undo icon after editing, and the global undo sometimes failed to restore values until the user left and re‑entered the tab. This made it unclear whether a change was recorded and slowed down workflows in the filament (material) settings panel.

How to reproduce

Open the Filament preset edit panel
Modify values such as adaptive/max volumetric speed, nozzle temperatures, flow ratio, or override retraction/ironing values
Observe missing undo icons or global undo not restoring immediately
Switch tabs and return — values appear reverted

What’s changed

Indexed filament settings are now tracked consistently, so undo markers appear correctly.
Override fields like retraction lift bounds and filament‑level ironing are now tracked as indexed settings
Indexed settings keep undo behavior correct today and align with future per‑nozzle variants within a single filament preset.

Result

Undo icons appear consistently next to all relevant filament fields
Global undo reverts immediately, without tab switching or other refresh tricks
Filament overrides behave predictably across editing sessions

Fixes #11525 (together with #11517)

*Originally created by @kisslorand on 12/20/2025* This PR fixes filament preset undo behavior so edited values reliably revert immediately, without needing a tab switch or any other refresh workaround. **What was wrong** Some filament settings showed no local undo icon after editing, and the global undo sometimes failed to restore values until the user left and re‑entered the tab. This made it unclear whether a change was recorded and slowed down workflows in the filament (material) settings panel. **How to reproduce** - Open the Filament preset edit panel - Modify values such as adaptive/max volumetric speed, nozzle temperatures, flow ratio, or override retraction/ironing values - Observe missing undo icons or global undo not restoring immediately - Switch tabs and return — values appear reverted **What’s changed** - Indexed filament settings are now tracked consistently, so undo markers appear correctly. - Override fields like retraction lift bounds and filament‑level ironing are now tracked as indexed settings - Indexed settings keep undo behavior correct today and align with future per‑nozzle variants within a single filament preset. **Result** - Undo icons appear consistently next to all relevant filament fields - Global undo reverts immediately, without tab switching or other refresh tricks - Filament overrides behave predictably across editing sessions Fixes #11525 (together with #11517)

MrUnknownDE closed this issue

2026-04-05 17:19:17 +02:00

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#1315