Fix the OnText handler in ObjectTableDialog to close on Esc. #130

New Issue

MrUnknownDE · 2026-04-05T16:18:34+02:00

MrUnknownDE commented

2026-04-05 16:18:34 +02:00

Originally created by @Jo-Con-El on 3/27/2026

Description

The OnText handler in ObjectTableDialog catches WXK_ESCAPE but swallows it. Invert the logic to call Close() on Esc, and pass anything else to evt.Skip().

While at it, fix a typo in the dialog's title.

Tests

None. I haven't been able to build OrcaSlicer on macOS due to an error building "dep_GMP".

*Originally created by @Jo-Con-El on 3/27/2026* # Description The OnText handler in ObjectTableDialog catches WXK_ESCAPE but swallows it. Invert the logic to call Close() on Esc, and pass anything else to evt.Skip(). While at it, fix a typo in the dialog's title. ## Tests None. I haven't been able to build OrcaSlicer on macOS due to an error building "dep_GMP".

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#130