Fix inconsistent ordering of support base outline and fill #1251

New Issue

MrUnknownDE · 2026-04-05T17:06:26+02:00

MrUnknownDE commented

2026-04-05 17:06:26 +02:00

Originally created by @kisslorand on 12/27/2025

Description

This PR fixes an issue in support base generation where the ordering between outline and fill was not consistently enforced.

The intended behavior is for each support base to:

1. Generate and print its outline first
2. Immediately follow with its base fill

In practice, ordering could vary. In some cases the fill was generated before the outline for the same support base. In others, the outline of a support base was generated, followed by base geometry of other supports, with the fill added only later.

What this PR changes

Enforces a strict per-support ordering: outline → fill
Prevents both order inversion (fill before outline) and cross-support interleaving
Does not alter geometry, extrusion parameters, or visual output

Scope

Affects support base path ordering only
No impact on non-support features

Result

Support bases are now generated deterministically with outline followed immediately by fill.

Fixes #10711

Screenshots

Before:

After:

*Originally created by @kisslorand on 12/27/2025* ## Description This PR fixes an issue in support base generation where the **ordering between outline and fill was not consistently enforced.** The intended behavior is for each support base to: **1.** Generate and print its outline first **2.** Immediately follow with its base fill In practice, ordering could vary. In some cases the fill was generated before the outline for the same support base. In others, the outline of a support base was generated, followed by base geometry of other supports, with the fill added only later. ## What this PR changes - Enforces a strict per-support ordering: outline → fill - Prevents both order inversion (fill before outline) and cross-support interleaving - Does not alter geometry, extrusion parameters, or visual output ## Scope - Affects support base path ordering only - No impact on non-support features ## Result Support bases are now generated deterministically with outline followed immediately by fill. Fixes #10711 ### Screenshots - **Before:** <img width="954" height="697" alt="image" src="https://github.com/user-attachments/assets/e0be37b3-8ea5-4d26-af28-5b0e0bdf7ec0" /> <br><br> - **After:** <img width="890" height="553" alt="image" src="https://github.com/user-attachments/assets/a6bb45b9-ef3a-4e01-95d5-d17500c6e2f5" />

Sign in to join this conversation.

No Label

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github/OrcaSlicer#1251