Fix: Dirty-state marker ("*") not shown for edited system printer presets #1125

Open
opened 2026-04-05 16:52:16 +02:00 by MrUnknownDE · 0 comments
Owner

Originally created by @kisslorand on 1/9/2026

Summary

When editing a system printer preset, the sidebar did not show the usual “*” marker that indicates the preset has changes. All other preset types filament, process, etc.) already show this marker correctly.

What this PR does

This PR ensures that system printer presets display the modified (“*”) prefix when:

  • the preset is system or default, and
  • it is the currently selected preset, and
  • it is marked dirty (edited)

Why this matters

Without this fix, users receive no visual indication that a system printer preset has been edited.
This is inconsistent with how all other presets behave and can cause confusion.

Result

System printer presets now correctly display the “*” dirty-state indicator when edited, matching the behavior of all other preset types.

Notes

  • Affects only sidebar display of system printer presets
  • No changes to selection behavior, preset storage, or underlying preset logic
  • No impact on user-created printer presets

Fixes #11705

Screenshots

  • Before:
    image

  • After:
    image

*Originally created by @kisslorand on 1/9/2026* ### Summary When editing a system printer preset, the sidebar **did not show** the usual “*” marker that indicates **the preset has changes**. All other preset types filament, process, etc.) already show this marker correctly. ### What this PR does This PR ensures that system printer presets display the modified (“*”) prefix when: - the preset is system or default, and - it is the currently selected preset, and - it is marked dirty (edited) ### Why this matters Without this fix, users receive **no visual indication** that a system printer **preset has been edited**. This is inconsistent with how all other presets behave and can cause confusion. ### Result System printer presets now **correctly display the “*” dirty-state indicator** when edited, matching the behavior of all other preset types. ### Notes - Affects only sidebar display of system printer presets - No changes to selection behavior, preset storage, or underlying preset logic - No impact on user-created printer presets Fixes #11705 ## Screenshots - __Before:__ <img width="403" height="375" alt="image" src="https://github.com/user-attachments/assets/cd8070bd-30ce-4a4f-b6b4-c5d34944173a" /> - __After:__ <img width="403" height="370" alt="image" src="https://github.com/user-attachments/assets/611d157f-6d27-4d0a-b58d-8f3cf92312da" />
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github/OrcaSlicer#1125