refactor: app.js (#1291)

* refactor: frontend

* Fix avatar gallery sort

* Update .NET dependencies

* Update npm dependencies

electron v37.1.0

* bulkRefreshFriends

* fix dark theme

* Remove crowdin

* Fix config.json dialog not updating

* VRCX log file fixes & add Cef log

* Remove SharedVariable, fix startup

* Revert init theme change

* Logging date not working? Fix WinformThemer designer error

* Add Cef request hander, no more escaping main page

* clean

* fix

* fix

* clean

* uh

* Apply thememode at startup, fixes random user colours

* Split database into files

* Instance info remove empty lines

* Open external VRC links with VRCX

* Electron fixes

* fix userdialog style

* ohhhh

* fix store

* fix store

* fix: load all group members after kicking a user

* fix: world dialog favorite button style

* fix: Clear VRCX Cache Timer input value

* clean

* Fix VR overlay

* Fix VR overlay 2

* Fix Discord discord rich presence for RPC worlds

* Clean up age verified user tags

* Fix playerList being occupied after program reload

* no `this`

* Fix login stuck loading

* writable: false

* Hide dialogs on logout

* add flush sync option

* rm LOGIN event

* rm LOGOUT event

* remove duplicate event listeners

* remove duplicate event listeners

* clean

* remove duplicate event listeners

* clean

* fix theme style

* fix t

* clearable

* clean

* fix ipcEvent

* Small changes

* Popcorn Palace support

* Remove checkActiveFriends

* Clean up

* Fix dragEnterCef

* Block API requests when not logged in

* Clear state on login & logout

* Fix worldDialog instances not updating

* use <script setup>

* Fix avatar change event, CheckGameRunning at startup

* Fix image dragging

* fix

* Remove PWI

* fix updateLoop

* add webpack-dev-server to dev environment

* rm unnecessary chunks

* use <script setup>

* webpack-dev-server changes

* use <script setup>

* use <script setup>

* Fix UGC text size

* Split login event

* t

* use <script setup>

* fix

* Update .gitignore and enable checkJs in jsconfig

* fix i18n t

* use <script setup>

* use <script setup>

* clean

* global types

* fix

* use checkJs for debugging

* Add watchState for login watchers

* fix .vue template

* type fixes

* rm Vue.filter

* Cef v138.0.170, VC++ 2022

* Settings fixes

* Remove 'USER:CURRENT'

* clean up 2FA callbacks

* remove userApply

* rm i18n import

* notification handling to use notification store methods

* refactor favorite handling to use favorite store methods and clean up event emissions

* refactor moderation handling to use dedicated functions for player moderation events

* refactor friend handling to use dedicated functions for friend events

* Fix program startup, move lang init

* Fix friend state

* Fix status change error

* Fix user notes diff

* fix

* rm group event

* rm auth event

* rm avatar event

* clean

* clean

* getUser

* getFriends

* getFavoriteWorlds, getFavoriteAvatars

* AvatarGalleryUpload btn style & package.json update

* Fix friend requests

* Apply user

* Apply world

* Fix note diff

* Fix VR overlay

* Fixes

* Update build scripts

* Apply avatar

* Apply instance

* Apply group

* update hidden VRC+ badge

* Fix sameInstance "private"

* fix 502/504 API errors

* fix 502/504 API errors

* clean

* Fix friend in same instance on orange showing twice in friends list

* Add back in broken friend state repair methods

* add types

---------

Co-authored-by: Natsumi <cmcooper123@hotmail.com>

src/vr.js

@@ -9,16 +9,18 @@ import '@fontsource/noto-sans-jp';
 import '@fontsource/noto-sans-sc';
 import '@fontsource/noto-sans-tc';
 import '@infolektuell/noto-color-emoji';
+import ElementUI from 'element-ui';
 import Noty from 'noty';
 import Vue from 'vue';
 import VueI18n from 'vue-i18n';
-import ElementUI from 'element-ui';
-import * as workerTimers from 'worker-timers';
 import MarqueeText from 'vue-marquee-text-component';
-import { displayLocation, parseLocation } from './composables/instance/utils';
+import * as workerTimers from 'worker-timers';
 import * as localizedStrings from './localization/localizedStrings.js';
 
-import $utils from './classes/utils.js';
+import { displayLocation, parseLocation } from './shared/utils/location';
+import { escapeTag, escapeTagRecursive } from './shared/utils/base/string';
+import { removeFromArray } from './shared/utils/base/array';
+import { timeToText } from './shared/utils/base/format';
 
 import pugTemplate from './vr.pug';
 
@@ -170,9 +172,7 @@ Vue.component('marquee-text', MarqueeText);
             notificationOpacity: 100
         },
         computed: {},
-        methods: {
-            ...$utils
-        },
+        methods: {},
         watch: {},
         el: '#root',
         async mounted() {
@@ -183,6 +183,7 @@ Vue.component('marquee-text', MarqueeText);
                 this.refreshCustomScript();
                 this.updateStatsLoop();
             }
+            this.setDatetimeFormat();
         }
     };
     Object.assign($app, app);
@@ -311,14 +312,14 @@ Vue.component('marquee-text', MarqueeText);
                 this.cpuUsage = cpuUsage.toFixed(0);
             }
             if (this.lastLocation.date !== 0) {
-                this.lastLocationTimer = $utils.timeToText(
+                this.lastLocationTimer = timeToText(
                     Date.now() - this.lastLocation.date
                 );
             } else {
                 this.lastLocationTimer = '';
             }
             if (this.lastLocation.onlineFor) {
-                this.onlineForTimer = $utils.timeToText(
+                this.onlineForTimer = timeToText(
                     Date.now() - this.lastLocation.onlineFor
                 );
             } else {
@@ -377,7 +378,7 @@ Vue.component('marquee-text', MarqueeText);
             if (this.config.pcUptimeOnFeed) {
                 AppApiVr.GetUptime().then((uptime) => {
                     if (uptime) {
-                        this.pcUptime = $utils.timeToText(uptime);
+                        this.pcUptime = timeToText(uptime);
                     }
                 });
             } else {
@@ -395,8 +396,8 @@ Vue.component('marquee-text', MarqueeText);
             console.error('noty is undefined');
             return;
         }
-        var noty = $utils.escapeTagRecursive(noty);
-        var message = $utils.escapeTag(message) || '';
+        var noty = escapeTagRecursive(noty);
+        var message = escapeTag(message) || '';
         var text = '';
         var img = '';
         if (image) {
@@ -607,7 +608,7 @@ Vue.component('marquee-text', MarqueeText);
         var dt = Date.now();
         this.hudFeed.forEach((item) => {
             if (item.time + this.config.photonOverlayMessageTimeout < dt) {
-                $utils.removeFromArray(this.hudFeed, item);
+                removeFromArray(this.hudFeed, item);
             }
         });
         if (this.hudFeed.length > 10) {
@@ -628,7 +629,7 @@ Vue.component('marquee-text', MarqueeText);
                 item.text === data.text
             ) {
                 combo = item.combo + 1;
-                $utils.removeFromArray(this.hudFeed, item);
+                removeFromArray(this.hudFeed, item);
             }
         });
         this.hudFeed.unshift({