refactor: app.js (#1291)

* refactor: frontend

* Fix avatar gallery sort

* Update .NET dependencies

* Update npm dependencies

electron v37.1.0

* bulkRefreshFriends

* fix dark theme

* Remove crowdin

* Fix config.json dialog not updating

* VRCX log file fixes & add Cef log

* Remove SharedVariable, fix startup

* Revert init theme change

* Logging date not working? Fix WinformThemer designer error

* Add Cef request hander, no more escaping main page

* clean

* fix

* fix

* clean

* uh

* Apply thememode at startup, fixes random user colours

* Split database into files

* Instance info remove empty lines

* Open external VRC links with VRCX

* Electron fixes

* fix userdialog style

* ohhhh

* fix store

* fix store

* fix: load all group members after kicking a user

* fix: world dialog favorite button style

* fix: Clear VRCX Cache Timer input value

* clean

* Fix VR overlay

* Fix VR overlay 2

* Fix Discord discord rich presence for RPC worlds

* Clean up age verified user tags

* Fix playerList being occupied after program reload

* no `this`

* Fix login stuck loading

* writable: false

* Hide dialogs on logout

* add flush sync option

* rm LOGIN event

* rm LOGOUT event

* remove duplicate event listeners

* remove duplicate event listeners

* clean

* remove duplicate event listeners

* clean

* fix theme style

* fix t

* clearable

* clean

* fix ipcEvent

* Small changes

* Popcorn Palace support

* Remove checkActiveFriends

* Clean up

* Fix dragEnterCef

* Block API requests when not logged in

* Clear state on login & logout

* Fix worldDialog instances not updating

* use <script setup>

* Fix avatar change event, CheckGameRunning at startup

* Fix image dragging

* fix

* Remove PWI

* fix updateLoop

* add webpack-dev-server to dev environment

* rm unnecessary chunks

* use <script setup>

* webpack-dev-server changes

* use <script setup>

* use <script setup>

* Fix UGC text size

* Split login event

* t

* use <script setup>

* fix

* Update .gitignore and enable checkJs in jsconfig

* fix i18n t

* use <script setup>

* use <script setup>

* clean

* global types

* fix

* use checkJs for debugging

* Add watchState for login watchers

* fix .vue template

* type fixes

* rm Vue.filter

* Cef v138.0.170, VC++ 2022

* Settings fixes

* Remove 'USER:CURRENT'

* clean up 2FA callbacks

* remove userApply

* rm i18n import

* notification handling to use notification store methods

* refactor favorite handling to use favorite store methods and clean up event emissions

* refactor moderation handling to use dedicated functions for player moderation events

* refactor friend handling to use dedicated functions for friend events

* Fix program startup, move lang init

* Fix friend state

* Fix status change error

* Fix user notes diff

* fix

* rm group event

* rm auth event

* rm avatar event

* clean

* clean

* getUser

* getFriends

* getFavoriteWorlds, getFavoriteAvatars

* AvatarGalleryUpload btn style & package.json update

* Fix friend requests

* Apply user

* Apply world

* Fix note diff

* Fix VR overlay

* Fixes

* Update build scripts

* Apply avatar

* Apply instance

* Apply group

* update hidden VRC+ badge

* Fix sameInstance "private"

* fix 502/504 API errors

* fix 502/504 API errors

* clean

* Fix friend in same instance on orange showing twice in friends list

* Add back in broken friend state repair methods

* add types

---------

Co-authored-by: Natsumi <cmcooper123@hotmail.com>

src/api/friend.js

@@ -1,13 +1,14 @@
-// #region | API: Friend
+import { request } from '../service/request';
+import { useUserStore } from '../stores/user';
 
 const friendReq = {
     /**
      * Fetch friends of current user.
-     * @param {{ n: number, offset: number, offline: boolean }} params
-     * @returns {Promise<{json: any, params}>}
+     * @type {import('../types/friend').getFriends}
      */
     getFriends(params) {
-        return window.API.call('auth/user/friends', {
+        const userStore = useUserStore();
+        return request('auth/user/friends', {
             method: 'GET',
             params
         }).then((json) => {
@@ -15,7 +16,13 @@ const friendReq = {
                 json,
                 params
             };
-            window.API.$emit('FRIEND:LIST', args);
+            for (const user of args.json) {
+                if (!user.displayName) {
+                    console.error('/friends gave us garbage', user);
+                    continue;
+                }
+                userStore.applyUser(user);
+            }
             return args;
         });
     },
@@ -25,14 +32,13 @@ const friendReq = {
      * @returns {Promise<{json: T, params}>}
      */
     sendFriendRequest(params) {
-        return window.API.call(`user/${params.userId}/friendRequest`, {
+        return request(`user/${params.userId}/friendRequest`, {
             method: 'POST'
         }).then((json) => {
             const args = {
                 json,
                 params
             };
-            window.API.$emit('FRIEND:REQUEST', args);
             return args;
         });
     },
@@ -42,14 +48,13 @@ const friendReq = {
      * @returns {Promise<{json: any, params}>}
      */
     cancelFriendRequest(params) {
-        return window.API.call(`user/${params.userId}/friendRequest`, {
+        return request(`user/${params.userId}/friendRequest`, {
             method: 'DELETE'
         }).then((json) => {
             const args = {
                 json,
                 params
             };
-            // window.API.$emit('FRIEND:REQUEST:CANCEL', args);
             return args;
         });
     },
@@ -59,14 +64,13 @@ const friendReq = {
      * @returns {Promise<{json: any, params}>}
      */
     deleteFriend(params) {
-        return window.API.call(`auth/user/friends/${params.userId}`, {
+        return request(`auth/user/friends/${params.userId}`, {
             method: 'DELETE'
         }).then((json) => {
             const args = {
                 json,
                 params
             };
-            window.API.$emit('FRIEND:DELETE', args);
             return args;
         });
     },
@@ -76,7 +80,7 @@ const friendReq = {
      * @returns {Promise<{json: any, params}>}
      */
     getFriendStatus(params) {
-        return window.API.call(`user/${params.userId}/friendStatus`, {
+        return request(`user/${params.userId}/friendStatus`, {
             method: 'GET'
         }).then((json) => {
             console.log('getFriendStatus', json);
@@ -84,15 +88,12 @@ const friendReq = {
                 json,
                 params
             };
-            window.API.$emit('FRIEND:STATUS', args);
             return args;
         });
     },
 
-    // ------------------- need to test -------------------
-
     deleteHiddenFriendRequest(params, userId) {
-        return window.API.call(`user/${userId}/friendRequest`, {
+        return request(`user/${userId}/friendRequest`, {
             method: 'DELETE',
             params
         }).then((json) => {
@@ -101,11 +102,9 @@ const friendReq = {
                 params,
                 userId
             };
-            window.API.$emit('NOTIFICATION:HIDE', args);
             return args;
         });
     }
 };
-// #endregion
 
 export default friendReq;