From b28dec1b9940b86f08c6ecda7343f2313ef75eb3 Mon Sep 17 00:00:00 2001
From: pa <maplenagisa@gmail.com>
Date: Mon, 10 Nov 2025 12:08:03 +0900
Subject: [PATCH] fix: instanceJoinHistory not updating correctly (#1478)

---
 .../dialogs/WorldDialog/WorldDialog.vue       | 81 ++++++++++---------
 src/stores/instance.js                        | 10 +--
 2 files changed, 50 insertions(+), 41 deletions(-)

diff --git a/src/components/dialogs/WorldDialog/WorldDialog.vue b/src/components/dialogs/WorldDialog/WorldDialog.vue
index 818e2692..6cb82641 100644
--- a/src/components/dialogs/WorldDialog/WorldDialog.vue
+++ b/src/components/dialogs/WorldDialog/WorldDialog.vue
@@ -342,42 +342,44 @@
                         <template
                             v-if="isAgeGatedInstancesVisible || !(room.ageGate || room.location?.includes('~ageGate'))">
                             <div style="margin: 5px 0">
-                                <LocationWorld
-                                    :locationobject="room.$location"
-                                    :currentuserid="currentUser.id"
-                                    :worlddialogshortname="worldDialog.$location.shortName" />
-                                <Launch :location="room.tag" style="margin-left: 5px" />
-                                <InviteYourself
-                                    :location="room.$location.tag"
-                                    :shortname="room.$location.shortName"
-                                    style="margin-left: 5px" />
-                                <el-tooltip
-                                    placement="top"
-                                    :content="t('dialog.world.instances.refresh_instance_info')">
-                                    <el-button
-                                        size="small"
-                                        :icon="Refresh"
-                                        style="margin-left: 5px"
-                                        circle
-                                        @click="refreshInstancePlayerCount(room.tag)" />
-                                </el-tooltip>
-                                <el-tooltip
-                                    v-if="instanceJoinHistory.get(room.$location.tag)"
-                                    placement="top"
-                                    :content="t('dialog.previous_instances.info')">
-                                    <el-button
-                                        size="small"
-                                        :icon="DataLine"
-                                        style="margin-left: 5px"
-                                        plain
-                                        circle
-                                        @click="showPreviousInstancesInfoDialog(room.location)" />
-                                </el-tooltip>
-                                <LastJoin :location="room.$location.tag" :currentlocation="lastLocation.location" />
-                                <InstanceInfo
-                                    :location="room.tag"
-                                    :instance="room.ref"
-                                    :friendcount="room.friendCount" />
+                                <div class="flex-align-center">
+                                    <LocationWorld
+                                        :locationobject="room.$location"
+                                        :currentuserid="currentUser.id"
+                                        :worlddialogshortname="worldDialog.$location.shortName" />
+                                    <Launch :location="room.tag" style="margin-left: 5px" />
+                                    <InviteYourself
+                                        :location="room.$location.tag"
+                                        :shortname="room.$location.shortName"
+                                        style="margin-left: 5px" />
+                                    <el-tooltip
+                                        placement="top"
+                                        :content="t('dialog.world.instances.refresh_instance_info')">
+                                        <el-button
+                                            size="small"
+                                            :icon="Refresh"
+                                            style="margin-left: 5px"
+                                            circle
+                                            @click="refreshInstancePlayerCount(room.tag)" />
+                                    </el-tooltip>
+                                    <el-tooltip
+                                        v-if="instanceJoinHistory.get(room.$location.tag)"
+                                        placement="top"
+                                        :content="t('dialog.previous_instances.info')">
+                                        <el-button
+                                            size="small"
+                                            :icon="DataLine"
+                                            style="margin-left: 5px"
+                                            plain
+                                            circle
+                                            @click="showPreviousInstancesInfoDialog(room.location)" />
+                                    </el-tooltip>
+                                    <LastJoin :location="room.$location.tag" :currentlocation="lastLocation.location" />
+                                    <InstanceInfo
+                                        :location="room.tag"
+                                        :instance="room.ref"
+                                        :friendcount="room.friendCount" />
+                                </div>
                                 <div
                                     v-if="room.$location.userId || room.users.length"
                                     class="x-friend-list"
@@ -1400,3 +1402,10 @@
         D.visible = true;
     }
 </script>
+
+<style scoped>
+    .flex-align-center {
+        display: flex;
+        align-items: center;
+    }
+</style>
diff --git a/src/stores/instance.js b/src/stores/instance.js
index e2935101..ffa20169 100644
--- a/src/stores/instance.js
+++ b/src/stores/instance.js
@@ -16,7 +16,8 @@ import {
     hasGroupPermission,
     isRealInstance,
     parseLocation,
-    replaceBioSymbols
+    replaceBioSymbols,
+    replaceReactiveObject
 } from '../shared/utils';
 import { instanceRequest, userRequest, worldRequest } from '../api';
 import { database } from '../service/database';
@@ -79,7 +80,7 @@ export const useInstanceStore = defineStore('Instance', () => {
 
     const previousInstancesInfoDialogInstanceId = ref('');
 
-    let instanceJoinHistory = reactive(new Map());
+    const instanceJoinHistory = reactive(new Map());
 
     const currentInstanceUsersData = ref([]);
     const currentInstanceUsersTable = computed(() => {
@@ -116,9 +117,8 @@ export const useInstanceStore = defineStore('Instance', () => {
 
     async function getInstanceJoinHistory() {
         try {
-            instanceJoinHistory = reactive(
-                await database.getInstanceJoinHistory()
-            );
+            const data = await database.getInstanceJoinHistory();
+            replaceReactiveObject(instanceJoinHistory, data);
         } catch (error) {
             console.error('Failed to get instance join history:', error);
         }