From 684482daaf3532f5edf51f28e26c7d7a5c1edc08 Mon Sep 17 00:00:00 2001
From: pa <maplenagisa@gmail.com>
Date: Sun, 14 Dec 2025 03:04:58 +0900
Subject: [PATCH] fix: prevent memory leaks by disposing watchers in Location
 component

---
 src/components/Location.vue | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/src/components/Location.vue b/src/components/Location.vue
index fc53af2e..0935e9b8 100644
--- a/src/components/Location.vue
+++ b/src/components/Location.vue
@@ -22,7 +22,7 @@
 
 <script setup>
     import { Loading, Lock, WarnTriangleFilled } from '@element-plus/icons-vue';
-    import { ref, watch, watchEffect } from 'vue';
+    import { onBeforeUnmount, ref, watch } from 'vue';
     import { storeToRefs } from 'pinia';
     import { useI18n } from 'vue-i18n';
 
@@ -66,18 +66,20 @@
     const groupName = ref('');
     const isClosed = ref(false);
 
-    watchEffect(() => {
-        parse();
+    let isDisposed = false;
+    onBeforeUnmount(() => {
+        isDisposed = true;
     });
 
+    watch(() => [props.location, props.traveling, props.hint, props.grouphint], parse, { immediate: true });
+
     watch(
         () => lastInstanceApplied.value,
         (instanceId) => {
             if (instanceId === currentInstanceId()) {
                 parse();
             }
-        },
-        { immediate: true }
+        }
     );
 
     function currentInstanceId() {
@@ -88,6 +90,9 @@
     }
 
     function parse() {
+        if (isDisposed) {
+            return;
+        }
         text.value = '';
         region.value = '';
         strict.value = false;
@@ -122,7 +127,7 @@
             groupName.value = L.groupId;
             getGroupName(instanceId)
                 .then((name) => {
-                    if (name && currentInstanceId() === L.tag) {
+                    if (!isDisposed && name && currentInstanceId() === L.tag) {
                         groupName.value = name;
                     }
                 })
@@ -163,7 +168,7 @@
             if (typeof ref === 'undefined') {
                 getWorldName(L.worldId)
                     .then((name) => {
-                        if (name && currentInstanceId() === L.tag) {
+                        if (!isDisposed && name && currentInstanceId() === L.tag) {
                             if (L.instanceId) {
                                 text.value = `${name} #${instanceName} ${L.accessTypeName}`;
                             } else {