Fix up commands parsing, implement proper json parsing

components/CommandManager/CMakeLists.txt

@@ -1,4 +1,4 @@
 idf_component_register(SRCS "CommandManager/CommandManager.cpp"
   INCLUDE_DIRS "CommandManager"
-  REQUIRES ProjectConfig
+  REQUIRES ProjectConfig cJSON
 )

components/CommandManager/CommandManager/CommandManager.cpp

@@ -6,16 +6,52 @@ std::unique_ptr<Command> CommandManager::createCommand(CommandType type)
   {
   case CommandType::PING:
     return std::make_unique<PingCommand>();
-    break;
+  case CommandType::SET_WIFI:
-  case CommandType::UPDATE_WIFI:
+    return std::make_unique<setWiFiCommand>(projectConfig);
-    return std::make_unique<UpdateWifiCommand>(projectConfig);
   default:
     return nullptr;
   }
 }
 
-CommandResult CommandManager::executeFromJson(const std::string *json)
+CommandResult CommandManager::executeFromJson(std::string *json)
 {
-  // parse it, get a type of command, grab a command from the map based on type
+  cJSON *parsedJson = cJSON_Parse(json->c_str());
-  // parse the payload json, call execute on the command and return the result
+  if (parsedJson == nullptr)
+    return CommandResult::getErrorResult("Invalid JSON");
+
+  const cJSON *commandData = nullptr;
+  const cJSON *commands = cJSON_GetObjectItem(parsedJson, "commands");
+  cJSON_ArrayForEach(commandData, commands)
+  {
+    const cJSON *commandTypeString = cJSON_GetObjectItem(commandData, "command");
+    const cJSON *commandPayload = cJSON_GetObjectItem(commandData, "data");
+
+    auto commandType = commandTypeMap.at(std::string(commandTypeString->valuestring));
+    auto command = createCommand(commandType);
+
+    if (command == nullptr)
+    {
+      cJSON_Delete(parsedJson);
+      return CommandResult::getErrorResult("Unknown command");
+    }
+
+    std::string commandPayloadString = std::string(cJSON_Print(commandPayload));
+    cJSON_Delete(parsedJson);
+    return command->execute(commandPayloadString);
+  }
+
+  cJSON_Delete(parsedJson);
+  return CommandResult::getErrorResult("Commands missing");
+}
+
+CommandResult CommandManager::executeFromType(CommandType type, std::string *json)
+{
+  auto command = createCommand(type);
+
+  if (command == nullptr)
+  {
+    return CommandResult::getErrorResult("Unknown command");
+  }
+
+  return command->execute(*json);
 }

components/CommandManager/CommandManager/CommandManager.hpp

@@ -1,3 +1,6 @@
+#ifndef COMMANDMANAGER_HPP
+#define COMMANDMANAGER_HPP
+
 #include <ProjectConfig.hpp>
 #include <memory>
 #include <string>
@@ -6,8 +9,10 @@
 #include "CommandResult.hpp"
 #include "CommandSchema.hpp"
 #include "Commands.hpp"
+#include <cJSON.h>
 
-const enum CommandType {
+enum CommandType
+{
   None,
   PING,
   SET_WIFI,
@@ -32,5 +37,8 @@ public:
   CommandManager(ProjectConfig &projectConfig) : projectConfig(projectConfig) {};
   std::unique_ptr<Command> createCommand(CommandType type);
 
-  CommandResult executeFromJson(const std::string *json);
+  CommandResult executeFromJson(std::string *json);
+  CommandResult executeFromType(CommandType type, std::string *json);
 };
+
+#endif

components/CommandManager/CommandManager/CommandResult.hpp

@@ -1,3 +1,6 @@
+#ifndef COMMAND_RESULT
+#define COMMAND_RESULT
+
 class CommandResult
 {
 private:
@@ -37,3 +40,5 @@ public:
   std::string getSuccessMessage() const { return successMessage.value(); };
   std::string getErrorMessage() const { return errorMessage.value(); }
 };
+
+#endif

components/CommandManager/CommandManager/CommandSchema.hpp

@@ -1,3 +1,5 @@
+#ifndef COMMAND_SCHEMA_HPP
+#define COMMAND_SCHEMA_HPP
 class BasePayload
 {
 };
@@ -24,3 +26,5 @@ class deleteNetworkPayload : public BasePayload
 {
   std::optional<std::string> networkName;
 };
+
+#endif

components/CommandManager/CommandManager/Commands.cpp

@@ -1 +1,16 @@
 #include "Commands.hpp"
+
+CommandResult PingCommand::execute(std::string &jsonPayload)
+{
+  return CommandResult::getSuccessResult("pong");
+}
+
+WifiPayload setConfigCommand::parsePayload(std::string &jsonPayload)
+{
+  return WifiPayload();
+}
+
+CommandResult setConfigCommand::execute(std::string &jsonPayload)
+{
+  return CommandResult::getSuccessResult("pong");
+}

components/CommandManager/CommandManager/Commands.hpp

@@ -1,3 +1,5 @@
+#ifndef COMMANDS_HPP
+#define COMMANDS_HPP
 #include <ProjectConfig.hpp>
 #include <memory>
 #include <string>
@@ -8,31 +10,25 @@
 
 class Command
 {
+public:
   virtual ~Command() = default;
-  virtual CommandResult execute(const std::shared_ptr<BasePayload> &payload) = 0;
+  virtual CommandResult execute(std::string &jsonPayload) = 0;
-  virtual std::shared_ptr<BasePayload> parsePayload(const std::string *json) = 0;
 };
 
 class PingCommand : public Command
 {
 public:
-  CommandResult execute(const std::shared_ptr<BasePayload> &payload);
+  CommandResult execute(std::string &jsonPayload) override;
-  std::shared_ptr<BasePayload> parsePayload(const std::string *json);
 };
 
-class setConfigCommand : public Command
+class setWiFiCommand : public Command
 {
-public:
-  CommandResult execute(const std::shared_ptr<BasePayload> &payload);
-  std::shared_ptr<BasePayload> parsePayload(const std::string *json);
-};
-
-class UpdateWifiCommand : public Command
-{
-private:
   ProjectConfig &projectConfig;
 
 public:
-  UpdateWifiCommand(ProjectConfig &projectConfig) : projectConfig(projectConfig) {};
+  setWiFiCommand(ProjectConfig &projectConfig) : projectConfig(projectConfig) {};
-  CommandResult execute(const std::shared_ptr<BasePayload> &payload);
+  CommandResult execute(std::string &jsonPayload) override;
+  WifiPayload parsePayload(std::string &jsonPayload);
 };
+
+#endif

components/Preferences/Preferences/Preferences.hpp

@@ -84,4 +84,4 @@ public:
   size_t freeEntries();
 };
 
-#endif PREFERENCES_HPP
+#endif