From 74c6004ef87de4e7dd2b33560bb8e4355f8b318d Mon Sep 17 00:00:00 2001 From: PhosphorosVR Date: Fri, 1 Aug 2025 01:46:55 +0200 Subject: [PATCH] fix: Prevent buffer overflow in get_serial_number --- components/UVCStream/UVCStream/UVCStream.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/UVCStream/UVCStream/UVCStream.cpp b/components/UVCStream/UVCStream/UVCStream.cpp index d5667d0..761e43e 100644 --- a/components/UVCStream/UVCStream/UVCStream.cpp +++ b/components/UVCStream/UVCStream/UVCStream.cpp @@ -4,7 +4,7 @@ constexpr int UVC_MAX_FRAMESIZE_SIZE(75 * 1024); static const char *UVC_STREAM_TAG = "[UVC DEVICE]"; extern "C" { - static char serial_number_str[13]; + static char serial_number_str[18]; const char *get_uvc_device_name() { return deviceConfig->getMDNSConfig().hostname.c_str(); @@ -19,7 +19,7 @@ extern "C" { return CONFIG_TUSB_SERIAL_NUM; } - sniprintf(serial_number_str, sizeof(serial_number_str), "%02x:%02x:%02x:%02x:%02x:%02x", + sniprintf(serial_number_str, sizeof(serial_number_str), "%02X:%02X:%02X:%02X:%02X:%02X", mac_address[0], mac_address[1], mac_address[2], mac_address[3], mac_address[4], mac_address[5] ); }